fix(regex): faithfully match an empty set of browsers#1583
Merged
dangreen merged 1 commit intobrowserslist:masterfrom Apr 5, 2026
Merged
fix(regex): faithfully match an empty set of browsers#1583dangreen merged 1 commit intobrowserslist:masterfrom
dangreen merged 1 commit intobrowserslist:masterfrom
Conversation
If the query matches no browsers, generate /[]/ which matches nothing rather than /(?:)/ which matches everything. Signed-off-by: Anders Kaseorg <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1583 +/- ##
==========================================
- Coverage 87.45% 85.12% -2.33%
==========================================
Files 32 29 -3
Lines 2144 1365 -779
Branches 287 284 -3
==========================================
- Hits 1875 1162 -713
+ Misses 269 203 -66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dangreen
approved these changes
Apr 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the query matches no browsers, generate
/[]/which matches nothing rather than/(?:)/which matches everything.